patch: do not block response if user password check failed

2025-04-17 18:18:11 +00:00 · 2024-03-06 17:14:17 -08:00 · 2024-03-06 17:14:17 -08:00 · 273d824df4
commit 273d824df4
parent 60fc5f715a
1 changed files with 11 additions and 8 deletions
--- a/server/endpoints/admin.js
+++ b/server/endpoints/admin.js
@ -59,14 +59,17 @@ function adminEndpoints(app) {
        }

        const { user: newUser, error } = await User.create(newUserParams);
-        await EventLogs.logEvent(
-          "user_created",
-          {
-            userName: newUser.username,
-            createdBy: currUser.username,
-          },
-          currUser.id
-        );
+        if (!!newUser) {
+          await EventLogs.logEvent(
+            "user_created",
+            {
+              userName: newUser.username,
+              createdBy: currUser.username,
+            },
+            currUser.id
+          );
+        }
+
        response.status(200).json({ user: newUser, error });
      } catch (e) {
        console.error(e);