From bfc9a96e87012a45a8626bcc69ee045f536fa416 Mon Sep 17 00:00:00 2001
From: timothycarambat <rambat1010@gmail.com>
Date: Thu, 23 May 2024 10:46:12 -0700
Subject: [PATCH] patch: bug when disabling password protection being invalid
even though it should be disabled
---
server/endpoints/system.js | 21 ++++++++++++++-------
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/server/endpoints/system.js b/server/endpoints/system.js
index f87eb7baa..253f20b7e 100644
--- a/server/endpoints/system.js
+++ b/server/endpoints/system.js
@@ -436,14 +436,21 @@ function systemEndpoints(app) {
return;
}
+ let error = null;
const { usePassword, newPassword } = reqBody(request);
- const { error } = await updateENV(
- {
- AuthToken: usePassword ? newPassword : "",
- JWTSecret: usePassword ? v4() : "",
- },
- true
- );
+ if (!usePassword) { // Password is being disabled so directly unset everything to bypass validation.
+ process.env.AUTH_TOKEN = "";
+ process.env.JWT_SECRET = "";
+ } else {
+ error = await updateENV(
+ {
+ AuthToken: newPassword,
+ JWTSecret: v4(),
+ },
+ true
+ )?.error;
+ }
+
if (process.env.NODE_ENV === "production") await dumpENV();
response.status(200).json({ success: !error, error });
} catch (e) {