sij/mapnik
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

add note to contributing guide about using pull requests for lite code review on big changes

Browse source
This commit is contained in:
Dane Springmeyer 2011-10-25 15:48:33 -07:00
parent 19665b9bba
commit 1d18a18639
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
docs/contributing.markdown
View file

@ -25,6 +25,10 @@ You will also notice that we don't use many of the standard geo libraries when w
## Code commits best practices. ## Code commits best practices.
#### Big changes - awesome as pull requests
We love big, aggressive refactoring - but ideally in branches. Even if the changes should go directly into the mainline code and are stable, very big changes are useful to see as a group and branches are cheap. So, branch and commit then create a pull request against master so that other developers can take a quick look. This is a great way for informal code review when a full issue is not warrented.
#### Commits that fix issues should note the issue # #### Commits that fix issues should note the issue #
git commit plugins/input/ogr/ -m "implemented sql query in OGR plugin (closes #472)" git commit plugins/input/ogr/ -m "implemented sql query in OGR plugin (closes #472)"