From 20b154ae49f1e822194eb93223b51f11c6f00695 Mon Sep 17 00:00:00 2001 From: Artem Pavlenko Date: Mon, 28 Oct 2024 11:02:08 +0000 Subject: [PATCH] Remove 'final' specifier as it was breaking `dynamic_cast` in 'is_valid' test when building on macOS arm64 ``` Apple clang version 16.0.0 (clang-1600.0.26.3) Target: arm64-apple-darwin24.0.0 ``` Also remove empty dtor as not required --- include/mapnik/featureset.hpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/include/mapnik/featureset.hpp b/include/mapnik/featureset.hpp index cd1235afb..e300ff120 100644 --- a/include/mapnik/featureset.hpp +++ b/include/mapnik/featureset.hpp @@ -41,10 +41,9 @@ struct MAPNIK_DECL Featureset : private util::noncopyable virtual ~Featureset() {} }; -struct MAPNIK_DECL invalid_featureset final : Featureset +struct MAPNIK_DECL invalid_featureset : Featureset { feature_ptr next() { return feature_ptr(); } - ~invalid_featureset() {} }; using featureset_ptr = std::shared_ptr;