From 2291c8b698a140222ccb64d4f4081593a16e975a Mon Sep 17 00:00:00 2001 From: Dane Springmeyer Date: Fri, 24 May 2013 12:46:51 -0700 Subject: [PATCH] disable hidden visibility for plugins and hidden inlines for the library by default for 2.2 release - can re-enable after more testing - refs #1863 --- SConstruct | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/SConstruct b/SConstruct index 29b6ae11c..2a52d5c87 100644 --- a/SConstruct +++ b/SConstruct @@ -1650,7 +1650,9 @@ if not preconfigured: if env['DEBUG']: env.Append(CXXFLAGS = common_cxx_flags + '-O0 -fno-inline') else: - env.Append(CXXFLAGS = common_cxx_flags + '-O%s -fvisibility-inlines-hidden -fno-strict-aliasing -finline-functions -Wno-inline -Wno-parentheses -Wno-char-subscripts' % (env['OPTIMIZATION'])) + # TODO - add back -fvisibility-inlines-hidden + # https://github.com/mapnik/mapnik/issues/1863 + env.Append(CXXFLAGS = common_cxx_flags + '-O%s -fno-strict-aliasing -finline-functions -Wno-inline -Wno-parentheses -Wno-char-subscripts' % (env['OPTIMIZATION'])) if env['DEBUG_UNDEFINED']: env.Append(CXXFLAGS = '-fsanitize=undefined-trap -fsanitize-undefined-trap-on-error -ftrapv -fwrapv') @@ -1765,8 +1767,6 @@ if not HELP_REQUESTED: Export('env') plugin_base = env.Clone() - if not env['DEBUG']: - plugin_base.Append(CXXFLAGS='-fvisibility=hidden') Export('plugin_base')