sij/mapnik
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

proper use of std:: in safe_cast

Browse source
This commit is contained in:
Dane Springmeyer 2015-06-15 19:34:16 -07:00
parent 427f0486ff
commit 48d4bfb170
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
include/mapnik/safe_cast.hpp
View file

@ -25,6 +25,7 @@
#include <limits> #include <limits>
#include <type_traits> #include <type_traits>
#include <cstdint>
namespace mapnik { namespace mapnik {
@ -60,11 +61,11 @@ struct numeric_compare<T,S,typename std::enable_if<!std::is_floating_point<T>::v
std::is_integral<T>::value && std::is_signed<T>::value && std::is_unsigned<S>::value>::type> std::is_integral<T>::value && std::is_signed<T>::value && std::is_unsigned<S>::value>::type>
{ {
static inline bool less(T t, S s) { static inline bool less(T t, S s) {
return (t < static_cast<T>(0)) ? true : static_cast<uint64_t>(t) < static_cast<uint64_t>(s); return (t < static_cast<T>(0)) ? true : static_cast<std::uint64_t>(t) < static_cast<std::uint64_t>(s);
} }
static inline bool greater(T t, S s) { static inline bool greater(T t, S s) {
return (t < static_cast<T>(0)) ? false : static_cast<uint64_t>(t) > static_cast<uint64_t>(s); return (t < static_cast<T>(0)) ? false : static_cast<std::uint64_t>(t) > static_cast<std::uint64_t>(s);
} }
}; };
@ -73,11 +74,11 @@ struct numeric_compare<T,S,typename std::enable_if<!std::is_floating_point<T>::v
std::is_integral<T>::value && std::is_unsigned<T>::value && std::is_signed<S>::value>::type> std::is_integral<T>::value && std::is_unsigned<T>::value && std::is_signed<S>::value>::type>
{ {
static inline bool less(T t, S s) { static inline bool less(T t, S s) {
return (s < static_cast<S>(0)) ? false : static_cast<uint64_t>(t) < static_cast<uint64_t>(s); return (s < static_cast<S>(0)) ? false : static_cast<std::uint64_t>(t) < static_cast<std::uint64_t>(s);
} }
static inline bool greater(T t, S s) { static inline bool greater(T t, S s) {
return (s < static_cast<S>(0)) ? true : static_cast<uint64_t>(t) > static_cast<uint64_t>(s); return (s < static_cast<S>(0)) ? true : static_cast<std::uint64_t>(t) > static_cast<std::uint64_t>(s);
} }
}; };