sij/mapnik
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

handle lacking return value handling caught by coverity

Browse source
This commit is contained in:
Dane Springmeyer 2013-07-04 14:31:46 -04:00
parent f31e04ec6c
commit 4bc28d547b
3 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
benchmark/run.cpp
View file

@ -900,7 +900,10 @@ int main( int argc, char** argv)
} }
{ {
mapnik::freetype_engine::register_fonts("./fonts", true); bool success = mapnik::freetype_engine::register_fonts("./fonts", true);
if (!success) {
std::clog << "warning, did not register any new fonts!\n";
}
unsigned face_count = mapnik::freetype_engine::face_names().size(); unsigned face_count = mapnik::freetype_engine::face_names().size();
test13 runner(1000,10); test13 runner(1000,10);
benchmark(runner, (boost::format("font_engihe: created %ld faces in ") % (face_count * 1000 * 10)).str()); benchmark(runner, (boost::format("font_engihe: created %ld faces in ") % (face_count * 1000 * 10)).str());

3
bindings/python/mapnik_feature.cpp
View file

@ -54,7 +54,8 @@ boost::ptr_vector<mapnik::geometry_type> const& (mapnik::feature_impl::*get_path
void feature_add_geometries_from_wkb(mapnik::feature_impl &feature, std::string wkb) void feature_add_geometries_from_wkb(mapnik::feature_impl &feature, std::string wkb)
{ {
geometry_utils::from_wkb(feature.paths(), wkb.c_str(), wkb.size()); bool result = geometry_utils::from_wkb(feature.paths(), wkb.c_str(), wkb.size());
if (!result) throw std::runtime_error("Failed to parse WKB");
} }
void feature_add_geometries_from_wkt(mapnik::feature_impl &feature, std::string wkt) void feature_add_geometries_from_wkt(mapnik::feature_impl &feature, std::string wkt)

5
utils/pgsql2sqlite/pgsql2sqlite.hpp
View file

@ -212,7 +212,10 @@ void pgsql2sqlite(Connection conn,
if ( rs->next()) if ( rs->next())
{ {
mapnik::util::string2int(rs->getValue("srid"),srid); if (!mapnik::util::string2int(rs->getValue("srid"),srid))
{
std::clog << "could not convert srid to integer\n";
}
geom_col = rs->getValue("f_geometry_column"); geom_col = rs->getValue("f_geometry_column");
geom_type = rs->getValue("type"); geom_type = rs->getValue("type");
} }