sij/mapnik
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

remove blank undelimited rows are still parsed section as current behavior is to fail and continue on individual row errors

Browse source
This commit is contained in:
artemp 2015-09-30 15:40:42 +01:00
parent 81628d5b9c
commit 54609fd8ac
1 changed files with 0 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
test/standalone/csv_test.cpp
View file

@ -555,20 +555,6 @@ TEST_CASE("csv") {
} }
} // END SECTION } // END SECTION
SECTION("blank undelimited rows are still parsed") {
using ustring = mapnik::value_unicode_string;
// TODO: does this mean this CSV file should be in the warnings
// subdirectory, since it doesn't work in strict mode?
auto ds = get_csv_ds("test/data/csv/more_headers_than_column_values.csv", false);
auto fields = ds->get_descriptor().get_descriptors();
require_field_names(fields, {"x", "y", "one", "two", "three"});
require_field_types(fields, {mapnik::Integer, mapnik::Integer, mapnik::String, mapnik::String, mapnik::String});
require_attributes(all_features(ds)->next(), {
attr{"x", 0}, attr{"y", 0}, attr{"one", ustring("")}, attr{"two", ustring("")}, attr{"three", ustring("")} });
} // END SECTION
SECTION("fewer headers than rows throws") { SECTION("fewer headers than rows throws") {
REQUIRE_THROWS(get_csv_ds("test/data/csv/more_column_values_than_headers.csv")); REQUIRE_THROWS(get_csv_ds("test/data/csv/more_column_values_than_headers.csv"));
} // END SECTION } // END SECTION