Merge pull request #2193 from strk/2.3.x-no-terminate-pgis-dtor

Do not throw in postgis_datasource destruction if backend is down

plugins/input/postgis/postgis_datasource.cpp

@@ -445,11 +445,20 @@ postgis_datasource::~postgis_datasource()
         CnxPool_ptr pool = ConnectionManager::instance().getPool(creator_.id());
         if (pool)
         {
+            try {
               shared_ptr<Connection> conn = pool->borrowObject();
               if (conn)
               {
                   conn->close();
               }
+            } catch (mapnik::datasource_exception const& ex) {
+              // happens when borrowObject tries to
+              // create a new connection and fails.
+              // In turn, new connection would be needed
+              // when our broke and was thus no good to
+              // be borrowed
+              // See https://github.com/mapnik/mapnik/issues/2191
+            }
         }
     }
 }