diff --git a/SConstruct b/SConstruct index 642ea1d96..36a4b87f1 100644 --- a/SConstruct +++ b/SConstruct @@ -1766,11 +1766,6 @@ if not preconfigured: # TODO: clean up code more to make -Wextra -Wsign-compare -Wsign-conversion -Wconversion viable common_cxx_flags = '-Wall %s %s -ftemplate-depth-300 -Wsign-compare -Wshadow ' % (env['WARNING_CXXFLAGS'], pthread) - if 'clang++' in env['CXX']: - common_cxx_flags += ' -Wno-unknown-pragmas -Wno-unsequenced ' - elif 'g++' in env['CXX']: - common_cxx_flags += ' -Wno-pragmas ' - if env['DEBUG']: env.Append(CXXFLAGS = common_cxx_flags + '-O0') else: diff --git a/include/mapnik/attribute_collector.hpp b/include/mapnik/attribute_collector.hpp index 878bfd4d4..cfd29cc6b 100644 --- a/include/mapnik/attribute_collector.hpp +++ b/include/mapnik/attribute_collector.hpp @@ -39,12 +39,8 @@ #include #include -// boost #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wconversion" +#include #include #pragma GCC diagnostic pop diff --git a/include/mapnik/css_color_grammar.hpp b/include/mapnik/css_color_grammar.hpp index 04ff02d55..21e639179 100644 --- a/include/mapnik/css_color_grammar.hpp +++ b/include/mapnik/css_color_grammar.hpp @@ -30,11 +30,7 @@ // boost #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wconversion" +#include #include #include #include diff --git a/include/mapnik/expression_grammar.hpp b/include/mapnik/expression_grammar.hpp index 5bb132f05..ff9423ea3 100644 --- a/include/mapnik/expression_grammar.hpp +++ b/include/mapnik/expression_grammar.hpp @@ -29,15 +29,9 @@ #include #include #include -//#include -// boost + #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wsign-compare" -#pragma GCC diagnostic ignored "-Wconversion" +#include #include #include #include diff --git a/include/mapnik/expression_grammar_impl.hpp b/include/mapnik/expression_grammar_impl.hpp index 93b6d868e..9c82cb8c5 100644 --- a/include/mapnik/expression_grammar_impl.hpp +++ b/include/mapnik/expression_grammar_impl.hpp @@ -30,14 +30,8 @@ #include #include -// boost #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wsign-compare" -#pragma GCC diagnostic ignored "-Wconversion" +#include #include #include #include diff --git a/include/mapnik/geometry_adapters.hpp b/include/mapnik/geometry_adapters.hpp index 3f08c2b92..7a708463a 100644 --- a/include/mapnik/geometry_adapters.hpp +++ b/include/mapnik/geometry_adapters.hpp @@ -27,11 +27,7 @@ // undef B0 to workaround https://svn.boost.org/trac/boost/ticket/10467 #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wconversion" -#pragma GCC diagnostic ignored "-Wunused-parameter" +#include #undef B0 #include #include diff --git a/include/mapnik/geometry_correct.hpp b/include/mapnik/geometry_correct.hpp index dcbb2d7ab..dc83ad3a2 100644 --- a/include/mapnik/geometry_correct.hpp +++ b/include/mapnik/geometry_correct.hpp @@ -28,12 +28,7 @@ #include #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-variable" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wconversion" +#include #include #pragma GCC diagnostic pop diff --git a/include/mapnik/grid/grid_pixfmt.hpp b/include/mapnik/grid/grid_pixfmt.hpp index fbd6f5173..dda24121f 100644 --- a/include/mapnik/grid/grid_pixfmt.hpp +++ b/include/mapnik/grid/grid_pixfmt.hpp @@ -27,9 +27,7 @@ #include #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wconversion" +#include #include "agg_basics.h" #include #pragma GCC diagnostic pop diff --git a/include/mapnik/grid/grid_renderer_base.hpp b/include/mapnik/grid/grid_renderer_base.hpp index 462010b6a..1000083df 100644 --- a/include/mapnik/grid/grid_renderer_base.hpp +++ b/include/mapnik/grid/grid_renderer_base.hpp @@ -24,9 +24,7 @@ #define MAPNIK_GRID_RENDERER_BASE_HPP #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wconversion" +#include #include "agg_renderer_base.h" #include #pragma GCC diagnostic pop diff --git a/include/mapnik/image_filter.hpp b/include/mapnik/image_filter.hpp index 3b188a36a..62a3f3b5b 100644 --- a/include/mapnik/image_filter.hpp +++ b/include/mapnik/image_filter.hpp @@ -29,14 +29,8 @@ #include #include -// boost GIL #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wc++11-narrowing" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wconversion" +#include #include #pragma GCC diagnostic pop diff --git a/include/mapnik/image_filter_grammar.hpp b/include/mapnik/image_filter_grammar.hpp index c35143808..04ced605b 100644 --- a/include/mapnik/image_filter_grammar.hpp +++ b/include/mapnik/image_filter_grammar.hpp @@ -23,14 +23,8 @@ #ifndef MAPNIK_IMAGE_FILITER_GRAMMAR_HPP #define MAPNIK_IMAGE_FILITER_GRAMMAR_HPP -// boost #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wsign-compare" -#pragma GCC diagnostic ignored "-Wconversion" +#include #include #include #pragma GCC diagnostic pop diff --git a/include/mapnik/image_filter_grammar_impl.hpp b/include/mapnik/image_filter_grammar_impl.hpp index e41f63ede..4dfa54038 100644 --- a/include/mapnik/image_filter_grammar_impl.hpp +++ b/include/mapnik/image_filter_grammar_impl.hpp @@ -24,9 +24,8 @@ #include #include -// spirit #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wsign-conversion" +#include #include #pragma GCC diagnostic pop diff --git a/include/mapnik/image_util.hpp b/include/mapnik/image_util.hpp index 1207bb80b..0db5a3752 100644 --- a/include/mapnik/image_util.hpp +++ b/include/mapnik/image_util.hpp @@ -27,12 +27,9 @@ #include #include #include -// boost + #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wconversion" +#include #include #include #pragma GCC diagnostic pop diff --git a/include/mapnik/json/error_handler.hpp b/include/mapnik/json/error_handler.hpp index 69bf02f6e..46a92c82e 100644 --- a/include/mapnik/json/error_handler.hpp +++ b/include/mapnik/json/error_handler.hpp @@ -25,8 +25,7 @@ #include #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wsign-compare" +#include #include #include #pragma GCC diagnostic pop diff --git a/include/mapnik/json/extract_bounding_box_grammar.hpp b/include/mapnik/json/extract_bounding_box_grammar.hpp index bfe9185bf..7d0b7a1ac 100644 --- a/include/mapnik/json/extract_bounding_box_grammar.hpp +++ b/include/mapnik/json/extract_bounding_box_grammar.hpp @@ -28,13 +28,9 @@ #include #include #include -// boost + #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wconversion" +#include #include #include #include diff --git a/include/mapnik/json/feature_grammar.hpp b/include/mapnik/json/feature_grammar.hpp index bb2d0c6ca..a4bdfa15e 100644 --- a/include/mapnik/json/feature_grammar.hpp +++ b/include/mapnik/json/feature_grammar.hpp @@ -33,7 +33,7 @@ #include #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wsign-conversion" +#include #include #include #include diff --git a/include/mapnik/json/generic_json.hpp b/include/mapnik/json/generic_json.hpp index 8f70adbf4..331341066 100644 --- a/include/mapnik/json/generic_json.hpp +++ b/include/mapnik/json/generic_json.hpp @@ -28,12 +28,7 @@ #include #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wsign-compare" -#pragma GCC diagnostic ignored "-Wconversion" +#include #include #include #pragma GCC diagnostic pop diff --git a/include/mapnik/json/geometry_generator_grammar.hpp b/include/mapnik/json/geometry_generator_grammar.hpp index 1095d32c2..eb484b698 100644 --- a/include/mapnik/json/geometry_generator_grammar.hpp +++ b/include/mapnik/json/geometry_generator_grammar.hpp @@ -30,11 +30,7 @@ #include // boost #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wconversion" +#include #include #include #include // for vc++ and android whose c++11 libs lack std::trunc diff --git a/include/mapnik/json/geometry_generator_grammar_impl.hpp b/include/mapnik/json/geometry_generator_grammar_impl.hpp index f94498065..62d6a85ff 100644 --- a/include/mapnik/json/geometry_generator_grammar_impl.hpp +++ b/include/mapnik/json/geometry_generator_grammar_impl.hpp @@ -27,11 +27,7 @@ // boost #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wconversion" +#include #include #include #include diff --git a/include/mapnik/json/positions_grammar.hpp b/include/mapnik/json/positions_grammar.hpp index 9e81dc8ad..a652e8f59 100644 --- a/include/mapnik/json/positions_grammar.hpp +++ b/include/mapnik/json/positions_grammar.hpp @@ -29,13 +29,9 @@ #include #include #include -// boost + #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wconversion" +#include #include #include #include diff --git a/include/mapnik/json/properties_generator_grammar.hpp b/include/mapnik/json/properties_generator_grammar.hpp index 781d807ea..e0f7be632 100644 --- a/include/mapnik/json/properties_generator_grammar.hpp +++ b/include/mapnik/json/properties_generator_grammar.hpp @@ -27,13 +27,8 @@ #include #include -// boost #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wconversion" +#include #include #include #include diff --git a/include/mapnik/json/topojson_grammar.hpp b/include/mapnik/json/topojson_grammar.hpp index 1cc967e01..be64b9168 100644 --- a/include/mapnik/json/topojson_grammar.hpp +++ b/include/mapnik/json/topojson_grammar.hpp @@ -29,13 +29,8 @@ #include #include -// boost #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wconversion" +#include #include #include #pragma GCC diagnostic pop diff --git a/include/mapnik/json/topology.hpp b/include/mapnik/json/topology.hpp index 48453df70..b859cfc55 100644 --- a/include/mapnik/json/topology.hpp +++ b/include/mapnik/json/topology.hpp @@ -27,7 +27,7 @@ #include #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wshadow" +#include #include #include #include diff --git a/include/mapnik/palette.hpp b/include/mapnik/palette.hpp index 377967aea..5f9627239 100644 --- a/include/mapnik/palette.hpp +++ b/include/mapnik/palette.hpp @@ -31,7 +31,7 @@ #define USE_DENSE_HASH_MAP #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wsign-conversion" +#include #ifdef USE_DENSE_HASH_MAP #include using rgba_hash_table = google::dense_hash_map; diff --git a/include/mapnik/params_impl.hpp b/include/mapnik/params_impl.hpp index 469a9361e..f127c4cf2 100644 --- a/include/mapnik/params_impl.hpp +++ b/include/mapnik/params_impl.hpp @@ -29,13 +29,8 @@ #include #include -// boost #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wconversion" +#include #include #include #pragma GCC diagnostic pop diff --git a/include/mapnik/path_expression_grammar.hpp b/include/mapnik/path_expression_grammar.hpp index 04d422aff..61a3db7ed 100644 --- a/include/mapnik/path_expression_grammar.hpp +++ b/include/mapnik/path_expression_grammar.hpp @@ -26,13 +26,8 @@ // mapnik #include -// boost #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wconversion" +#include #include #pragma GCC diagnostic pop diff --git a/include/mapnik/proj_strategy.hpp b/include/mapnik/proj_strategy.hpp index 9bfd2e15e..064f3669b 100644 --- a/include/mapnik/proj_strategy.hpp +++ b/include/mapnik/proj_strategy.hpp @@ -29,11 +29,7 @@ #include #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wconversion" +#include #include #include #include diff --git a/include/mapnik/sql_utils.hpp b/include/mapnik/sql_utils.hpp index d90a55f09..2720e8424 100644 --- a/include/mapnik/sql_utils.hpp +++ b/include/mapnik/sql_utils.hpp @@ -28,11 +28,7 @@ // boost #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wconversion" +#include #include #pragma GCC diagnostic pop diff --git a/include/mapnik/svg/geometry_svg_generator.hpp b/include/mapnik/svg/geometry_svg_generator.hpp index e70166f03..11aa5c9c1 100644 --- a/include/mapnik/svg/geometry_svg_generator.hpp +++ b/include/mapnik/svg/geometry_svg_generator.hpp @@ -33,13 +33,8 @@ #include #include -// boost #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wconversion" +#include #include #include #include diff --git a/include/mapnik/svg/output/svg_output_grammars.hpp b/include/mapnik/svg/output/svg_output_grammars.hpp index 3a47e4332..769671bfc 100644 --- a/include/mapnik/svg/output/svg_output_grammars.hpp +++ b/include/mapnik/svg/output/svg_output_grammars.hpp @@ -36,13 +36,8 @@ namespace mapnik { namespace svg { struct root_output_attributes; }} -// boost #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wconversion" +#include #include #include #include diff --git a/include/mapnik/svg/output/svg_output_grammars_impl.hpp b/include/mapnik/svg/output/svg_output_grammars_impl.hpp index 41f69282e..cbce9196b 100644 --- a/include/mapnik/svg/output/svg_output_grammars_impl.hpp +++ b/include/mapnik/svg/output/svg_output_grammars_impl.hpp @@ -26,13 +26,8 @@ // mapnik #include -// boost #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wconversion" +#include #include #include #pragma GCC diagnostic pop diff --git a/include/mapnik/svg/svg_path_commands.hpp b/include/mapnik/svg/svg_path_commands.hpp index 105b4cabc..cf69e13a5 100644 --- a/include/mapnik/svg/svg_path_commands.hpp +++ b/include/mapnik/svg/svg_path_commands.hpp @@ -25,14 +25,10 @@ // mapnik #include +#include -// boost #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wconversion" +#include #include #include #include diff --git a/include/mapnik/svg/svg_points_grammar.hpp b/include/mapnik/svg/svg_points_grammar.hpp index dbaed8480..94602cc3f 100644 --- a/include/mapnik/svg/svg_points_grammar.hpp +++ b/include/mapnik/svg/svg_points_grammar.hpp @@ -25,11 +25,14 @@ // mapnik #include -// spirit + +#pragma GCC diagnostic push +#include #include #include #include #include +#pragma GCC diagnostic pop namespace mapnik { namespace svg { diff --git a/include/mapnik/svg/svg_renderer_agg.hpp b/include/mapnik/svg/svg_renderer_agg.hpp index ad24cb912..ad574cc62 100644 --- a/include/mapnik/svg/svg_renderer_agg.hpp +++ b/include/mapnik/svg/svg_renderer_agg.hpp @@ -32,9 +32,7 @@ #if defined(GRID_RENDERER) #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wconversion" +#include #include #pragma GCC diagnostic pop #endif diff --git a/include/mapnik/svg/svg_transform_grammar.hpp b/include/mapnik/svg/svg_transform_grammar.hpp index e0f5231aa..1465f3a2a 100644 --- a/include/mapnik/svg/svg_transform_grammar.hpp +++ b/include/mapnik/svg/svg_transform_grammar.hpp @@ -29,13 +29,8 @@ // agg #include -// boost #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wconversion" +#include #include #include #include diff --git a/include/mapnik/util/container_adapter.hpp b/include/mapnik/util/container_adapter.hpp index e07d7091f..8c70c4c2a 100644 --- a/include/mapnik/util/container_adapter.hpp +++ b/include/mapnik/util/container_adapter.hpp @@ -24,16 +24,10 @@ #define CONTAINER_ADAPTER_HPP // mapnik - - #include -// boost #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wconversion" +#include #include #pragma GCC diagnostic pop diff --git a/include/mapnik/util/spirit_transform_attribute.hpp b/include/mapnik/util/spirit_transform_attribute.hpp index f7fb1ca43..c4176f1fa 100644 --- a/include/mapnik/util/spirit_transform_attribute.hpp +++ b/include/mapnik/util/spirit_transform_attribute.hpp @@ -28,13 +28,8 @@ #include -// boost #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wconversion" +#include #include #pragma GCC diagnostic pop diff --git a/include/mapnik/warning_ignore.hpp b/include/mapnik/warning_ignore.hpp new file mode 100644 index 000000000..bde83fba0 --- /dev/null +++ b/include/mapnik/warning_ignore.hpp @@ -0,0 +1,35 @@ +/***************************************************************************** + * + * This file is part of Mapnik (c++ mapping toolkit) + * + * Copyright (C) 2015 Artem Pavlenko + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * + *****************************************************************************/ + + +#pragma GCC diagnostic ignored "-Wno-unknown-pragmas" // clang +#pragma GCC diagnostic ignored "-Wno-pragmas" // gcc +#pragma GCC diagnostic ignored "-Wno-unsequenced" +#pragma GCC diagnostic ignored "-Wunused-function" +#pragma GCC diagnostic ignored "-Wunused-parameter" +#pragma GCC diagnostic ignored "-Wredeclared-class-member" +#pragma GCC diagnostic ignored "-Wunused-local-typedef" +#pragma GCC diagnostic ignored "-Wshadow" +#pragma GCC diagnostic ignored "-Wc++11-narrowing" +#pragma GCC diagnostic ignored "-Wsign-conversion" +#pragma GCC diagnostic ignored "-Wsign-compare" +#pragma GCC diagnostic ignored "-Wconversion" \ No newline at end of file diff --git a/include/mapnik/webp_io.hpp b/include/mapnik/webp_io.hpp index b16a8917a..225ff2f50 100644 --- a/include/mapnik/webp_io.hpp +++ b/include/mapnik/webp_io.hpp @@ -27,9 +27,8 @@ #include #include -// webp #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-function" +#include extern "C" { #include diff --git a/include/mapnik/wkt/wkt_generator_grammar.hpp b/include/mapnik/wkt/wkt_generator_grammar.hpp index e4a396959..0c89601d7 100644 --- a/include/mapnik/wkt/wkt_generator_grammar.hpp +++ b/include/mapnik/wkt/wkt_generator_grammar.hpp @@ -29,13 +29,8 @@ #include #include -// boost #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wconversion" +#include #include #include #include // for vc++ and android whose c++11 libs lack std::trunc diff --git a/include/mapnik/wkt/wkt_grammar.hpp b/include/mapnik/wkt/wkt_grammar.hpp index 54e9674c5..a91f43692 100644 --- a/include/mapnik/wkt/wkt_grammar.hpp +++ b/include/mapnik/wkt/wkt_grammar.hpp @@ -26,13 +26,9 @@ // mapnik #include #include + #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wsign-compare" -#pragma GCC diagnostic ignored "-Wconversion" +#include #include #include #include diff --git a/include/mapnik/xml_attribute_cast.hpp b/include/mapnik/xml_attribute_cast.hpp index 5140fde3c..fb3b7ebdc 100644 --- a/include/mapnik/xml_attribute_cast.hpp +++ b/include/mapnik/xml_attribute_cast.hpp @@ -36,9 +36,8 @@ #include #include -// boost #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wsign-conversion" +#include #include #pragma GCC diagnostic pop diff --git a/plugins/input/csv/csv_datasource.cpp b/plugins/input/csv/csv_datasource.cpp index 0a8acb89c..d0dbf06d9 100644 --- a/plugins/input/csv/csv_datasource.cpp +++ b/plugins/input/csv/csv_datasource.cpp @@ -43,8 +43,7 @@ #include #if defined(MAPNIK_MEMORY_MAPPED_FILE) #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wsign-conversion" +#include #include #include #pragma GCC diagnostic pop diff --git a/plugins/input/csv/csv_datasource.hpp b/plugins/input/csv/csv_datasource.hpp index 3faf0cf8e..ac2482f9b 100644 --- a/plugins/input/csv/csv_datasource.hpp +++ b/plugins/input/csv/csv_datasource.hpp @@ -33,18 +33,13 @@ #include #include -// boost -#include #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-variable" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wconversion" +#include +#include #include #include #pragma GCC diagnostic pop + // stl #include #include diff --git a/plugins/input/csv/csv_featureset.hpp b/plugins/input/csv/csv_featureset.hpp index e09bd4c60..8fbf77bb8 100644 --- a/plugins/input/csv/csv_featureset.hpp +++ b/plugins/input/csv/csv_featureset.hpp @@ -32,8 +32,7 @@ #if defined(MAPNIK_MEMORY_MAPPED_FILE) #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wsign-conversion" +#include #include #include #pragma GCC diagnostic pop diff --git a/plugins/input/csv/csv_index_featureset.hpp b/plugins/input/csv/csv_index_featureset.hpp index a17da5997..1a2c6372b 100644 --- a/plugins/input/csv/csv_index_featureset.hpp +++ b/plugins/input/csv/csv_index_featureset.hpp @@ -31,8 +31,7 @@ #if defined(MAPNIK_MEMORY_MAPPED_FILE) #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wsign-conversion" +#include #include #include #pragma GCC diagnostic pop diff --git a/plugins/input/csv/csv_utils.hpp b/plugins/input/csv/csv_utils.hpp index b1894da4e..43da304ea 100644 --- a/plugins/input/csv/csv_utils.hpp +++ b/plugins/input/csv/csv_utils.hpp @@ -33,11 +33,9 @@ #include #include #include -// boost + #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wsign-conversion" +#include #include #pragma GCC diagnostic pop diff --git a/plugins/input/geojson/geojson_datasource.cpp b/plugins/input/geojson/geojson_datasource.cpp index 28648c026..b46bf5bc7 100644 --- a/plugins/input/geojson/geojson_datasource.cpp +++ b/plugins/input/geojson/geojson_datasource.cpp @@ -27,14 +27,8 @@ #include #include -// boost #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wsign-compare" -#pragma GCC diagnostic ignored "-Wmissing-field-initializers" -#pragma GCC diagnostic ignored "-Wsign-conversion" +#include #include #include #pragma GCC diagnostic pop @@ -64,8 +58,7 @@ #if defined(MAPNIK_MEMORY_MAPPED_FILE) #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wsign-conversion" +#include #include #pragma GCC diagnostic pop #include diff --git a/plugins/input/geojson/geojson_datasource.hpp b/plugins/input/geojson/geojson_datasource.hpp index 212796c11..66f338337 100644 --- a/plugins/input/geojson/geojson_datasource.hpp +++ b/plugins/input/geojson/geojson_datasource.hpp @@ -33,15 +33,9 @@ #include #include -// boost -#include #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-variable" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wconversion" +#include +#include #include #include #pragma GCC diagnostic pop diff --git a/plugins/input/geojson/geojson_index_featureset.hpp b/plugins/input/geojson/geojson_index_featureset.hpp index 2cd934c25..41e8e84ba 100644 --- a/plugins/input/geojson/geojson_index_featureset.hpp +++ b/plugins/input/geojson/geojson_index_featureset.hpp @@ -29,8 +29,7 @@ #if defined(MAPNIK_MEMORY_MAPPED_FILE) #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wsign-conversion" +#include #include #include #pragma GCC diagnostic pop diff --git a/plugins/input/ogr/ogr_datasource.cpp b/plugins/input/ogr/ogr_datasource.cpp index 11f80ea19..41c0ebbe6 100644 --- a/plugins/input/ogr/ogr_datasource.cpp +++ b/plugins/input/ogr/ogr_datasource.cpp @@ -34,10 +34,8 @@ #include #include -// boost #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" +#include #include #pragma GCC diagnostic pop diff --git a/plugins/input/ogr/ogr_datasource.hpp b/plugins/input/ogr/ogr_datasource.hpp index f98aebfaa..0edeae9dc 100644 --- a/plugins/input/ogr/ogr_datasource.hpp +++ b/plugins/input/ogr/ogr_datasource.hpp @@ -40,9 +40,8 @@ #include #include -// ogr #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wshadow" +#include #include #pragma GCC diagnostic pop #include "ogr_layer_ptr.hpp" diff --git a/plugins/input/ogr/ogr_featureset.hpp b/plugins/input/ogr/ogr_featureset.hpp index ca7a57ab6..6a594ec52 100644 --- a/plugins/input/ogr/ogr_featureset.hpp +++ b/plugins/input/ogr/ogr_featureset.hpp @@ -29,9 +29,8 @@ #include #include -// ogr #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wshadow" +#include #include #pragma GCC diagnostic pop diff --git a/plugins/input/ogr/ogr_index_featureset.cpp b/plugins/input/ogr/ogr_index_featureset.cpp index 348c618f8..54b91f470 100644 --- a/plugins/input/ogr/ogr_index_featureset.cpp +++ b/plugins/input/ogr/ogr_index_featureset.cpp @@ -36,8 +36,7 @@ #if defined(MAPNIK_MEMORY_MAPPED_FILE) #include #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wsign-conversion" +#include #include #include #pragma GCC diagnostic pop diff --git a/plugins/input/pgraster/pgraster_datasource.cpp b/plugins/input/pgraster/pgraster_datasource.cpp index dc3e1a5b0..451c74e52 100644 --- a/plugins/input/pgraster/pgraster_datasource.cpp +++ b/plugins/input/pgraster/pgraster_datasource.cpp @@ -38,10 +38,8 @@ #include #include -// boost #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" +#include #include #include #pragma GCC diagnostic pop diff --git a/plugins/input/postgis/postgis_datasource.cpp b/plugins/input/postgis/postgis_datasource.cpp index bfc006bb6..d95aa3392 100644 --- a/plugins/input/postgis/postgis_datasource.cpp +++ b/plugins/input/postgis/postgis_datasource.cpp @@ -35,10 +35,8 @@ #include #include -// boost #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" +#include #include #include #include diff --git a/plugins/input/raster/raster_featureset.cpp b/plugins/input/raster/raster_featureset.cpp index 93f4b8d36..26cac964f 100644 --- a/plugins/input/raster/raster_featureset.cpp +++ b/plugins/input/raster/raster_featureset.cpp @@ -30,10 +30,8 @@ #include #include -// boost #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" +#include #include #include #pragma GCC diagnostic pop diff --git a/plugins/input/shape/dbfile.cpp b/plugins/input/shape/dbfile.cpp index 06ef7f795..d64d37384 100644 --- a/plugins/input/shape/dbfile.cpp +++ b/plugins/input/shape/dbfile.cpp @@ -28,14 +28,8 @@ #include "dbfile.hpp" -// boost #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wmissing-field-initializers" -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wsign-compare" +#include #include #if defined(MAPNIK_MEMORY_MAPPED_FILE) #include diff --git a/plugins/input/shape/dbfile.hpp b/plugins/input/shape/dbfile.hpp index 6812e5460..9ff022400 100644 --- a/plugins/input/shape/dbfile.hpp +++ b/plugins/input/shape/dbfile.hpp @@ -27,10 +27,11 @@ #include #include #include + #if defined(MAPNIK_MEMORY_MAPPED_FILE) #include #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wshadow" +#include #include #pragma GCC diagnostic pop #endif diff --git a/plugins/input/shape/shape_datasource.cpp b/plugins/input/shape/shape_datasource.cpp index f2a51601f..644e60135 100644 --- a/plugins/input/shape/shape_datasource.cpp +++ b/plugins/input/shape/shape_datasource.cpp @@ -24,11 +24,9 @@ #include "shape_featureset.hpp" #include "shape_index_featureset.hpp" -// boost -#include #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" +#include +#include #include #pragma GCC diagnostic pop diff --git a/plugins/input/shape/shape_index_featureset.cpp b/plugins/input/shape/shape_index_featureset.cpp index e352efd48..f91d7acf4 100644 --- a/plugins/input/shape/shape_index_featureset.cpp +++ b/plugins/input/shape/shape_index_featureset.cpp @@ -27,15 +27,14 @@ #include #include -// boost #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" +#include #include #if defined(MAPNIK_MEMORY_MAPPED_FILE) #include #endif #pragma GCC diagnostic pop + #include "shape_index_featureset.hpp" #include "shape_utils.hpp" #include diff --git a/plugins/input/shape/shape_utils.cpp b/plugins/input/shape/shape_utils.cpp index af7aa536c..40d8fc6c3 100644 --- a/plugins/input/shape/shape_utils.cpp +++ b/plugins/input/shape/shape_utils.cpp @@ -26,10 +26,8 @@ #include #include "shape_utils.hpp" -// boost #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" +#include #include #pragma GCC diagnostic pop diff --git a/plugins/input/shape/shapefile.hpp b/plugins/input/shape/shapefile.hpp index 1c61df0b8..664dc8852 100644 --- a/plugins/input/shape/shapefile.hpp +++ b/plugins/input/shape/shapefile.hpp @@ -33,10 +33,10 @@ #include #include #include + #if defined(MAPNIK_MEMORY_MAPPED_FILE) #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wsign-conversion" +#include #include #include #pragma GCC diagnostic pop diff --git a/plugins/input/sqlite/sqlite_connection.hpp b/plugins/input/sqlite/sqlite_connection.hpp index 27a2fe210..c87086d78 100644 --- a/plugins/input/sqlite/sqlite_connection.hpp +++ b/plugins/input/sqlite/sqlite_connection.hpp @@ -32,10 +32,8 @@ #include #include -// boost #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" +#include #include #pragma GCC diagnostic pop diff --git a/plugins/input/sqlite/sqlite_utils.hpp b/plugins/input/sqlite/sqlite_utils.hpp index c96f64005..959e3f7c6 100644 --- a/plugins/input/sqlite/sqlite_utils.hpp +++ b/plugins/input/sqlite/sqlite_utils.hpp @@ -38,10 +38,8 @@ #include #include -// boost #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" +#include #include #pragma GCC diagnostic pop diff --git a/plugins/input/topojson/topojson_datasource.hpp b/plugins/input/topojson/topojson_datasource.hpp index 214d40e09..ebc92aea2 100644 --- a/plugins/input/topojson/topojson_datasource.hpp +++ b/plugins/input/topojson/topojson_datasource.hpp @@ -33,15 +33,10 @@ #include #include #include -// boost -#include + #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-variable" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wconversion" +#include +#include #include #include #include diff --git a/plugins/input/topojson/topojson_featureset.cpp b/plugins/input/topojson/topojson_featureset.cpp index b82304b71..9e7c23ee4 100644 --- a/plugins/input/topojson/topojson_featureset.cpp +++ b/plugins/input/topojson/topojson_featureset.cpp @@ -33,11 +33,8 @@ #include #include -// boost #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-variable" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" +#include #include #pragma GCC diagnostic pop diff --git a/src/box2d.cpp b/src/box2d.cpp index a39857d24..0e60a3859 100644 --- a/src/box2d.cpp +++ b/src/box2d.cpp @@ -29,12 +29,10 @@ #include #include -// boost +#include + #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wconversion" +#include #include #include #include diff --git a/src/color.cpp b/src/color.cpp index b385877f5..2dcbe76c9 100644 --- a/src/color.cpp +++ b/src/color.cpp @@ -28,13 +28,8 @@ // agg #include "agg_color_rgba.h" -// boost #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wconversion" +#include #include #include #include diff --git a/src/conversions.cpp b/src/conversions.cpp index 995d0f439..04bfc5789 100644 --- a/src/conversions.cpp +++ b/src/conversions.cpp @@ -31,11 +31,7 @@ #define MAPNIK_KARMA_TO_STRING #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wconversion" +#include #include #ifdef MAPNIK_KARMA_TO_STRING #include diff --git a/src/dasharray_parser.cpp b/src/dasharray_parser.cpp index 489931954..760caea25 100644 --- a/src/dasharray_parser.cpp +++ b/src/dasharray_parser.cpp @@ -24,10 +24,7 @@ #include #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wconversion" +#include #include #include #include diff --git a/src/datasource_cache.cpp b/src/datasource_cache.cpp index f4124460c..c712f4adb 100644 --- a/src/datasource_cache.cpp +++ b/src/datasource_cache.cpp @@ -29,10 +29,8 @@ #include #include -// boost #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" +#include #include #include #pragma GCC diagnostic pop diff --git a/src/expression_node.cpp b/src/expression_node.cpp index 43a4059b9..377d091c9 100644 --- a/src/expression_node.cpp +++ b/src/expression_node.cpp @@ -26,7 +26,7 @@ #include #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wsign-conversion" +#include #if defined(BOOST_REGEX_HAS_ICU) #include #else diff --git a/src/font_engine_freetype.cpp b/src/font_engine_freetype.cpp index 8f62842cb..b0f137473 100644 --- a/src/font_engine_freetype.cpp +++ b/src/font_engine_freetype.cpp @@ -30,10 +30,8 @@ #include #include -// boost #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" +#include #include #include #pragma GCC diagnostic pop diff --git a/src/image_compositing.cpp b/src/image_compositing.cpp index 83684e442..12633cbc2 100644 --- a/src/image_compositing.cpp +++ b/src/image_compositing.cpp @@ -27,12 +27,8 @@ #include #include -// boost #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wredeclared-class-member" -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wconversion" +#include #include #include #pragma GCC diagnostic pop diff --git a/src/image_filter_types.cpp b/src/image_filter_types.cpp index 2212db998..6755757ec 100644 --- a/src/image_filter_types.cpp +++ b/src/image_filter_types.cpp @@ -24,14 +24,8 @@ #include #include -// boost #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wmissing-field-initializers" -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wconversion" +#include #include #pragma GCC diagnostic pop diff --git a/src/image_options.cpp b/src/image_options.cpp index 3b1b1fe07..bbcb6c909 100644 --- a/src/image_options.cpp +++ b/src/image_options.cpp @@ -23,11 +23,7 @@ #include #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wconversion" +#include #include #include #pragma GCC diagnostic pop diff --git a/src/image_scaling.cpp b/src/image_scaling.cpp index dd3dcebf2..63bb88c08 100644 --- a/src/image_scaling.cpp +++ b/src/image_scaling.cpp @@ -29,10 +29,7 @@ // boost #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wredeclared-class-member" -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wconversion" +#include #include #include #pragma GCC diagnostic pop diff --git a/src/jpeg_reader.cpp b/src/jpeg_reader.cpp index 4a6284cb8..84c805ee8 100644 --- a/src/jpeg_reader.cpp +++ b/src/jpeg_reader.cpp @@ -30,9 +30,8 @@ extern "C" #include } -// boost #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-local-typedef" +#include #include #include #include diff --git a/src/mapped_memory_cache.cpp b/src/mapped_memory_cache.cpp index 00ad96333..db4fce897 100644 --- a/src/mapped_memory_cache.cpp +++ b/src/mapped_memory_cache.cpp @@ -27,11 +27,9 @@ #include #include -// boost -#include #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wsign-conversion" +#include +#include #include #include #pragma GCC diagnostic pop diff --git a/src/marker_cache.cpp b/src/marker_cache.cpp index 330f4d094..664121854 100644 --- a/src/marker_cache.cpp +++ b/src/marker_cache.cpp @@ -33,10 +33,8 @@ #include #include -// boost #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" +#include #include #include #pragma GCC diagnostic pop diff --git a/src/miniz_png.cpp b/src/miniz_png.cpp index fb2658545..746cffa9d 100644 --- a/src/miniz_png.cpp +++ b/src/miniz_png.cpp @@ -31,8 +31,7 @@ #define MINIZ_NO_ZLIB_COMPATIBLE_NAMES #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wconversion" +#include extern "C" { #include "miniz.c" } diff --git a/src/png_reader.cpp b/src/png_reader.cpp index 03968c051..30b470fd6 100644 --- a/src/png_reader.cpp +++ b/src/png_reader.cpp @@ -28,9 +28,9 @@ extern "C" { #include } -// boost + #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-local-typedef" +#include #include #include #include diff --git a/src/save_map.cpp b/src/save_map.cpp index 7ba97579d..b8db98a78 100644 --- a/src/save_map.cpp +++ b/src/save_map.cpp @@ -48,16 +48,14 @@ #include #include -// boost #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-local-typedef" +#include #include -#pragma GCC diagnostic ignored "-Wsign-conversion" #include #include -#pragma GCC diagnostic pop #include #include +#pragma GCC diagnostic pop // stl #include diff --git a/src/simplify.cpp b/src/simplify.cpp index 97eae9257..51a5dfef5 100644 --- a/src/simplify.cpp +++ b/src/simplify.cpp @@ -1,12 +1,8 @@ // mapnik #include -// boost #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wredeclared-class-member" -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wconversion" +#include #include #include #pragma GCC diagnostic pop diff --git a/src/svg/output/svg_generator.cpp b/src/svg/output/svg_generator.cpp index 419696191..cb8eb79ec 100644 --- a/src/svg/output/svg_generator.cpp +++ b/src/svg/output/svg_generator.cpp @@ -27,13 +27,8 @@ #include #include -// boost #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wconversion" +#include #include #pragma GCC diagnostic pop diff --git a/src/svg/svg_parser.cpp b/src/svg/svg_parser.cpp index af02a7174..5885e8d9e 100644 --- a/src/svg/svg_parser.cpp +++ b/src/svg/svg_parser.cpp @@ -35,15 +35,12 @@ #include "agg_color_rgba.h" #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wsign-conversion" +#include #include #include #include #include #include -// rapidxml #include #pragma GCC diagnostic pop diff --git a/src/text/font_feature_settings.cpp b/src/text/font_feature_settings.cpp index 581c08501..81a62f9dd 100644 --- a/src/text/font_feature_settings.cpp +++ b/src/text/font_feature_settings.cpp @@ -24,16 +24,13 @@ #include #include -// boost #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wmissing-field-initializers" -#pragma GCC diagnostic ignored "-Wsign-conversion" +#include #include #include #pragma GCC diagnostic pop + // stl #include #include diff --git a/src/text/placements/simple.cpp b/src/text/placements/simple.cpp index 493da3f2f..800a3d3e3 100644 --- a/src/text/placements/simple.cpp +++ b/src/text/placements/simple.cpp @@ -30,14 +30,8 @@ #include #include -// boost #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wmissing-field-initializers" -#pragma GCC diagnostic ignored "-Wsign-conversion" -#pragma GCC diagnostic ignored "-Wsign-compare" -#pragma GCC diagnostic ignored "-Wconversion" +#include #include #include #include diff --git a/src/tiff_reader.cpp b/src/tiff_reader.cpp index dbafdf025..37e59b556 100644 --- a/src/tiff_reader.cpp +++ b/src/tiff_reader.cpp @@ -29,9 +29,8 @@ extern "C" #include } -// boost #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-local-typedef" +#include #include #include #include diff --git a/src/webp_reader.cpp b/src/webp_reader.cpp index fbd046064..c806df9c1 100644 --- a/src/webp_reader.cpp +++ b/src/webp_reader.cpp @@ -25,18 +25,14 @@ #include #include -#pragma clang diagnostic push -#pragma clang diagnostic ignored "-Wunused-function" +#pragma GCC diagnostic push +#include extern "C" { #include #include } -#pragma clang diagnostic pop -// boost -#pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-local-typedef" #include #include #include diff --git a/utils/mapnik-index/mapnik-index.cpp b/utils/mapnik-index/mapnik-index.cpp index bceaa64bb..a19b1f129 100644 --- a/utils/mapnik-index/mapnik-index.cpp +++ b/utils/mapnik-index/mapnik-index.cpp @@ -30,9 +30,9 @@ #include "process_csv_file.hpp" #include "process_geojson_file.hpp" + #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" +#include #include #include #pragma GCC diagnostic pop diff --git a/utils/mapnik-index/process_csv_file.cpp b/utils/mapnik-index/process_csv_file.cpp index c7b18a0e1..908ec9a79 100644 --- a/utils/mapnik-index/process_csv_file.cpp +++ b/utils/mapnik-index/process_csv_file.cpp @@ -27,8 +27,7 @@ #if defined(MAPNIK_MEMORY_MAPPED_FILE) #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wsign-conversion" +#include #include #include #pragma GCC diagnostic pop diff --git a/utils/mapnik-index/process_geojson_file.cpp b/utils/mapnik-index/process_geojson_file.cpp index 7c4bd514a..1ca0be752 100644 --- a/utils/mapnik-index/process_geojson_file.cpp +++ b/utils/mapnik-index/process_geojson_file.cpp @@ -29,10 +29,7 @@ #if defined(MAPNIK_MEMORY_MAPPED_FILE) #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-local-typedef" -#pragma GCC diagnostic ignored "-Wshadow" -#pragma GCC diagnostic ignored "-Wsign-compare" -#pragma GCC diagnostic ignored "-Wsign-conversion" +#include #include #include #include diff --git a/utils/mapnik-render/mapnik-render.cpp b/utils/mapnik-render/mapnik-render.cpp index e223cf086..0ed950cca 100644 --- a/utils/mapnik-render/mapnik-render.cpp +++ b/utils/mapnik-render/mapnik-render.cpp @@ -9,8 +9,7 @@ #include #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" +#include #include #include #pragma GCC diagnostic pop diff --git a/utils/pgsql2sqlite/pgsql2sqlite.hpp b/utils/pgsql2sqlite/pgsql2sqlite.hpp index f188e0861..e339a8f58 100644 --- a/utils/pgsql2sqlite/pgsql2sqlite.hpp +++ b/utils/pgsql2sqlite/pgsql2sqlite.hpp @@ -35,10 +35,8 @@ #include "connection_manager.hpp" #include "cursorresultset.hpp" -// boost #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" +#include #include #pragma GCC diagnostic pop diff --git a/utils/shapeindex/shapeindex.cpp b/utils/shapeindex/shapeindex.cpp index 2e03180d1..5555c203b 100644 --- a/utils/shapeindex/shapeindex.cpp +++ b/utils/shapeindex/shapeindex.cpp @@ -30,8 +30,7 @@ #include "shape_io.hpp" #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" +#include #include #include #pragma GCC diagnostic pop diff --git a/utils/svg2png/svg2png.cpp b/utils/svg2png/svg2png.cpp index 582e5e550..8e855fd91 100644 --- a/utils/svg2png/svg2png.cpp +++ b/utils/svg2png/svg2png.cpp @@ -35,8 +35,7 @@ #include #pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wunused-parameter" -#pragma GCC diagnostic ignored "-Wunused-local-typedef" +#include #include #include #pragma GCC diagnostic pop