From 8262eb5206415ff3a26fb4f7e7011afe714e86ea Mon Sep 17 00:00:00 2001 From: Dane Springmeyer Date: Tue, 29 Nov 2016 13:50:08 -0800 Subject: [PATCH] avoid -Wshadow and 'unrecognized command line option' with gcc --- include/mapnik/offset_converter.hpp | 10 +++++----- include/mapnik/simplify_converter.hpp | 12 ++++++------ scripts/travis-common.sh | 4 ++-- 3 files changed, 13 insertions(+), 13 deletions(-) diff --git a/include/mapnik/offset_converter.hpp b/include/mapnik/offset_converter.hpp index 0f0d1ceb4..c739c152d 100644 --- a/include/mapnik/offset_converter.hpp +++ b/include/mapnik/offset_converter.hpp @@ -77,18 +77,18 @@ struct offset_converter return threshold_; } - void set_offset(double value) + void set_offset(double val) { - if (offset_ != value) + if (offset_ != val) { - offset_ = value; + offset_ = val; reset(); } } - void set_threshold(double value) + void set_threshold(double val) { - threshold_ = value; + threshold_ = val; // no need to reset(), since threshold doesn't affect // offset vertices' computation, it only controls how // far will we be looking for self-intersections diff --git a/include/mapnik/simplify_converter.hpp b/include/mapnik/simplify_converter.hpp index 248842504..a8a6c377b 100644 --- a/include/mapnik/simplify_converter.hpp +++ b/include/mapnik/simplify_converter.hpp @@ -120,11 +120,11 @@ public: return algorithm_; } - void set_simplify_algorithm(simplify_algorithm_e value) + void set_simplify_algorithm(simplify_algorithm_e val) { - if (algorithm_ != value) + if (algorithm_ != val) { - algorithm_ = value; + algorithm_ = val; reset(); } } @@ -134,11 +134,11 @@ public: return tolerance_; } - void set_simplify_tolerance(double value) + void set_simplify_tolerance(double val) { - if (tolerance_ != value) + if (tolerance_ != val) { - tolerance_ = value; + tolerance_ = val; reset(); } } diff --git a/scripts/travis-common.sh b/scripts/travis-common.sh index 56909b79d..288fcc1ce 100644 --- a/scripts/travis-common.sh +++ b/scripts/travis-common.sh @@ -83,9 +83,9 @@ config_override () { configure () { if enabled ${COVERAGE}; then ./configure "$@" PREFIX=${PREFIX} PGSQL2SQLITE=False SVG2PNG=False SVG_RENDERER=False \ - COVERAGE=True DEBUG=True WARNING_CXXFLAGS="-Wno-unknown-warning-option" + COVERAGE=True DEBUG=True else - ./configure "$@" PREFIX=${PREFIX} WARNING_CXXFLAGS="-Wno-unknown-warning-option" + ./configure "$@" PREFIX=${PREFIX} fi # print final config values, sorted and indented sort -sk1,1 ./config.py | sed -e 's/^/ /'