diff --git a/CHANGELOG.md b/CHANGELOG.md index 6bd53aa0b..2ead70c40 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -17,6 +17,7 @@ Released: YYYY XX, 2015 - Visual tests: new command line arguments `--agg`, `--cairo`, `--svg`, `--grid` for selecting renderers (https://github.com/mapnik/mapnik/pull/3074) - Visual tests: new command line argument `--scale-factor` or abbreviated `-s` for setting scale factor (https://github.com/mapnik/mapnik/pull/3074) - Fixed parsing colors in hexadecimal notation (https://github.com/mapnik/mapnik/pull/3075) +- Removed mapnik::Feature type alias of mapnik::feature_impl (https://github.com/mapnik/mapnik/pull/3099) ## 3.0.5 diff --git a/include/mapnik/feature.hpp b/include/mapnik/feature.hpp index eb084bc0c..fff06a232 100644 --- a/include/mapnik/feature.hpp +++ b/include/mapnik/feature.hpp @@ -273,9 +273,6 @@ inline std::ostream& operator<< (std::ostream & out,feature_impl const& f) return out; } -// TODO - remove at Mapnik 3.x -using Feature = feature_impl; - using feature_ptr = std::shared_ptr; } diff --git a/include/mapnik/renderer_common/process_group_symbolizer.hpp b/include/mapnik/renderer_common/process_group_symbolizer.hpp index d593b8ead..edec30830 100644 --- a/include/mapnik/renderer_common/process_group_symbolizer.hpp +++ b/include/mapnik/renderer_common/process_group_symbolizer.hpp @@ -329,7 +329,7 @@ void render_group_symbolizer(group_symbolizer const& sym, // get the layout for this set of properties for (auto const& rule : props->get_rules()) { - if (util::apply_visitor(evaluate(*sub_feature,common.vars_), + if (util::apply_visitor(evaluate(*sub_feature,common.vars_), *(rule->get_filter())).to_bool()) { // add matched rule and feature to the list of things to draw @@ -380,7 +380,7 @@ void render_group_symbolizer(group_symbolizer const& sym, // evaluate the repeat key with the matched sub feature if we have one if (rpt_key_expr) { - rpt_key_value = util::apply_visitor(evaluate(*match_feature,common.vars_), + rpt_key_value = util::apply_visitor(evaluate(*match_feature,common.vars_), *rpt_key_expr).to_unicode(); } helper.add_box_element(layout_manager.offset_box_at(i), rpt_key_value); diff --git a/utils/pgsql2sqlite/pgsql2sqlite.hpp b/utils/pgsql2sqlite/pgsql2sqlite.hpp index 5c5a640c3..f188e0861 100644 --- a/utils/pgsql2sqlite/pgsql2sqlite.hpp +++ b/utils/pgsql2sqlite/pgsql2sqlite.hpp @@ -388,7 +388,7 @@ void pgsql2sqlite(Connection conn, { if (oid == geometry_oid) { - mapnik::Feature feat(ctx,pkid); + mapnik::feature_impl feat(ctx,pkid); mapnik::geometry::geometry geom = geometry_utils::from_wkb(buf, size, wkbGeneric); if (!mapnik::geometry::is_empty(geom)) {