From a8443df1a1225da57ff82af2ddd2a5e922091870 Mon Sep 17 00:00:00 2001 From: artemp Date: Wed, 28 Jan 2015 12:52:59 +0100 Subject: [PATCH] =?UTF-8?q?use=20perfect=20forwarding=20to=20resolve=20cop?= =?UTF-8?q?y/move=20semantics=20of=20universal=20references=20-=C2=A0#2651?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- include/mapnik/params.hpp | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/include/mapnik/params.hpp b/include/mapnik/params.hpp index 83e2934e2..240192c94 100644 --- a/include/mapnik/params.hpp +++ b/include/mapnik/params.hpp @@ -48,19 +48,11 @@ struct value_holder : value_holder_base value_holder() : value_holder_base() {} - // copy - value_holder(const char* val) - : value_holder_base(val) {} - - template - value_holder(T const& obj) - : value_holder_base(typename detail::mapnik_value_type::type(obj)) - {} - - // move + // perfect forwarding template value_holder(T && obj) noexcept - : value_holder_base(std::move(obj)) {} + : value_holder_base(std::forward(obj)) + {} }; using parameter = std::pair;