add TODO comments for grammars that are not stateless - refs #2231

This commit is contained in:
Dane Springmeyer 2014-04-30 11:04:26 -07:00
parent 356cc85ad8
commit ba17b9e374
2 changed files with 4 additions and 0 deletions

View file

@ -132,6 +132,8 @@ geojson_datasource::geojson_datasource(parameters const& params)
mapnik::context_ptr ctx = std::make_shared<mapnik::context_type>();
mapnik::json::generic_json<boost::spirit::multi_pass<base_iterator_type> > json;
// TODO - make it possible for this to be static const
// by avoiding ctor taking arg - https://github.com/mapnik/mapnik/pull/2231
mapnik::json::feature_collection_parser<boost::spirit::multi_pass<base_iterator_type> > p(json, ctx,*tr_);
bool result = p.parse(begin,end, features_);
if (!result)

View file

@ -35,6 +35,8 @@ namespace mapnik { namespace svg {
using namespace boost::spirit;
typedef const char * iterator_type;
typedef ascii::space_type skip_type;
// TODO - make it possible for this to be static const
// by avoiding ctor taking arg - https://github.com/mapnik/mapnik/pull/2231
svg_transform_grammar<iterator_type,skip_type,TransformType> g(p);
iterator_type first = wkt;
iterator_type last = wkt + std::strlen(wkt);