sij/mapnik
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

The last stripe of a tiff could be read incorrectly due to a swap

Browse source
This commit is contained in:
Blake Thompson 2017-05-17 17:06:40 -05:00
parent 599f187968
commit efcb667f03
1 changed files with 52 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

53
src/tiff_reader.cpp
View file

@ -169,6 +169,8 @@ private:
template <typename ImageData>
void read_stripped(std::size_t x,std::size_t y, ImageData & image);
void read_stripped(std::size_t x,std::size_t y, image_rgba8 & image);
template <typename ImageData>
void read_tiled(std::size_t x,std::size_t y, ImageData & image);
@ -530,10 +532,11 @@ struct tiff_reader_traits<image_rgba8>
{
if (TIFFReadRGBAStrip(tif, y, buf) != -1)
{
/*
for (std::size_t y = 0; y < rows_per_strip/2; ++y)
{
std::swap_ranges(buf + y * strip_width, buf + (y + 1) * strip_width, buf + (rows_per_strip - y - 1) * strip_width);
}
}*/
return true;
}
return false;
@ -719,6 +722,54 @@ void tiff_reader<T>::read_tiled(std::size_t x0,std::size_t y0, ImageData & image
}
}
template <typename T>
void tiff_reader<T>::read_stripped(std::size_t x0, std::size_t y0, image_rgba8 & image)
{
using pixel_type = typename detail::tiff_reader_traits<image_rgba8>::pixel_type;
TIFF* tif = open(stream_);
if (tif)
{
std::uint32_t strip_size = TIFFStripSize(tif);
std::unique_ptr<pixel_type[]> strip(new pixel_type[strip_size]);
std::size_t width = image.width();
std::size_t height = image.height();
std::size_t start_y = (y0 / rows_per_strip_) * rows_per_strip_;
std::size_t end_y = std::min(y0 + height, height_);
std::size_t tx0, tx1, ty0, ty1, rows_on_strip;
tx0 = x0;
tx1 = std::min(width + x0, width_);
rows_on_strip = rows_per_strip_;
std::size_t row = 0;
bool pick_first_band = (bands_ > 1) && (strip_size / (width_ * rows_per_strip_ * sizeof(pixel_type)) == bands_);
for (std::size_t y = start_y; y < end_y; y += rows_per_strip_)
{
ty0 = std::max(y0, y) - y;
ty1 = std::min(end_y, y + rows_per_strip_) - y;
rows_on_strip = std::min(end_y - y, static_cast<std::size_t>(rows_per_strip_));
if (!detail::tiff_reader_traits<image_rgba8>::read_strip(tif, y, rows_per_strip_, width_, strip.get()))
{
MAPNIK_LOG_DEBUG(tiff_reader) << "TIFFRead(Encoded|RGBA)Strip failed at " << y << " for " << width_ << "/" << height_ << "\n";
break;
}
if (pick_first_band)
{
std::uint32_t size = width_ * rows_per_strip_ * sizeof(pixel_type);
for (std::uint32_t n = 0; n < size; ++n)
{
strip[n] = strip[bands_ * n];
}
}
for (std::size_t ty = ty0; ty < ty1; ++ty)
{
image.set_row(row++, tx0 - x0, tx1 - x0, &strip[(rows_on_strip - ty - 1) * width_ + tx0]);
}
}
}
}
template <typename T>
template <typename ImageData>
void tiff_reader<T>::read_stripped(std::size_t x0, std::size_t y0, ImageData & image)