sij/mapnik
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add (currently failing) test for #2651

Browse source
This commit is contained in:
Dane Springmeyer 2015-01-22 18:25:37 -08:00
parent 4a1f4a9b5e
commit fcdc826294
1 changed files with 30 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
tests/cpp_tests/params_test.cpp
View file

@ -6,6 +6,22 @@
#include <vector> #include <vector>
#include <algorithm> #include <algorithm>
namespace detail {
class string_holder {
public:
string_holder() :
member_("member") {}
std::string const& get_string() const
{
return member_;
}
private:
std::string member_;
};
}
int main(int argc, char** argv) int main(int argc, char** argv)
{ {
std::vector<std::string> args; std::vector<std::string> args;
@ -79,6 +95,20 @@ int main(int argc, char** argv)
params["null"] = mapnik::value_null(); params["null"] = mapnik::value_null();
// https://github.com/mapnik/mapnik/issues/2471 // https://github.com/mapnik/mapnik/issues/2471
//BOOST_TEST( (params.get<mapnik::value_null>("null") && *params.get<mapnik::value_null>("null") == mapnik::value_null()) ); //BOOST_TEST( (params.get<mapnik::value_null>("null") && *params.get<mapnik::value_null>("null") == mapnik::value_null()) );
std::string rvalue("rvalue");
params["rvalue"] = rvalue;
BOOST_TEST(params.get<std::string>("rvalue") == std::string("rvalue"));
// Currently this fails because rvalue gets moved and nulled out
// Is this really the right behavior?
BOOST_TEST(rvalue == std::string("rvalue"));
// ensure that const member is not moved incorrectly when added to params
detail::string_holder holder;
std::string const& holder_member = holder.get_string();
params["member"] = holder_member;
BOOST_TEST(params.get<std::string>("member") == std::string("member"));
BOOST_TEST(holder_member == std::string("member"));
} }
catch (std::exception const& ex) catch (std::exception const& ex)
{ {