Dane Springmeyer
57dbd77819
more warning_ignore usage - refs #2907
2016-03-09 16:43:00 -08:00
artemp
3fab234e0a
update visual data submodule
2016-03-07 15:26:31 +01:00
Dane Springmeyer
fde36984de
minor unit test cleanups to prepare to test amalgamation
2016-03-03 10:53:58 -08:00
artemp
45b54c703c
apply_marker_multi - unroll template instantiation logic + drop 'GeometryCollection' support (experimental)
2016-03-01 17:28:09 +01:00
artemp
176d3e49c9
update test (ref f44b5ccfd9 #3237 #3238 )
2016-02-25 15:31:18 +01:00
artemp
c044b6d073
add relevant empty string/null equality ref #1859 #3255
2016-02-25 11:21:07 +01:00
artemp
9fe049d8af
CSV utils - strengthen quote detection logic + tests
2016-02-19 15:05:15 +01:00
artemp
62de76a66e
test bogus *.index files are handled correctly (ref #3300 ) + indirectly tests #3306 via requiring mapped_memory_cache::instance().clear()
2016-02-19 11:25:27 +01:00
artemp
c4817f7ae1
clear mapped_memory_cache to ensure new '*.index` are used (MAPNIK_MEMORY_MAPPED_FILE) (ref #3306 )
2016-02-19 11:02:12 +01:00
artemp
eb1a23d6e4
'invalid index' - testing invalid *.index fallback (ref #3300 )
2016-02-18 17:36:18 +01:00
Dane Springmeyer
4beda3bc46
fix #3290
2016-02-16 12:30:40 -08:00
artemp
ca0c0e5888
csv_util - combine auto-decting separator/quote/newline into one method std::tuple<char, bool, char, char> autodect_csv_flavour(T & stream, std::size_t file_length)
2016-02-15 13:55:06 +01:00
Mickey Rose
f19b8e8eff
test/expressions: add checks for backslash-escapes in strings
2016-02-15 02:23:19 +01:00
artemp
edc2e75474
Merge branch 'trim-filter-grammar' of https://github.com/lightmare/mapnik into lightmare-trim-filter-grammar
2016-02-11 15:43:18 +01:00
Dane Springmeyer
8ecb42894f
restore << operator for mapnik::enumeration + add unit test
2016-02-09 10:08:29 -08:00
artemp
f0cc65958f
Merge branch 'expr-no-barewords' of https://github.com/lightmare/mapnik into lightmare-expr-no-barewords
2016-02-09 14:15:22 +01:00
artemp
c53b4cdeda
update test data ref #3288
2016-02-09 11:44:55 +01:00
Mickey Rose
ae39d48b86
test/expressions: add checks for logical operator precedence
2016-02-06 14:26:57 +01:00
Mickey Rose
401dfacfc5
test/image_filter: prevent SIGSEGV when parsing fails
2016-02-06 01:56:05 +01:00
Mickey Rose
5764d619f3
expressions test: move expression strings into Catch calls, continue on failure
2016-02-05 17:22:01 +01:00
Mickey Rose
53bb55eade
rename expresssions_test.cpp, didn't pass spell check
2016-02-05 17:22:01 +01:00
artemp
cb708d7f5a
transform_grammar: correct and simplify rules per bcc7495a87 (commitcomment-15915607)
...
image_filter: relax `agg-stack-blur` rule to allow `agg-stack-blur,agg-stack-blur(),agg-stack-blur(1),agg-stack-blur(1,1)` syntax + add image filter parsing tests
2016-02-05 16:50:49 +01:00
Mickey Rose
7594301d98
test/shapeindex: include loop variables in failure message
...
[skip ci]
2016-02-04 18:54:21 +01:00
artemp
13af423046
unit test - use 'parse_image_filters' and avoid instantiating expensive redundant grammar
2016-02-02 11:30:00 +01:00
Dane Springmeyer
a447c78d2e
ensure valid objects in shapeindex test
2016-01-29 16:30:03 -08:00
Dane Springmeyer
c786ff9edf
postgis unit test: copy params to ensure that each test is independent and order does not matter
2016-01-27 12:55:26 -08:00
artemp
d027ed67c7
more const strictness, update to work with latest mapbox::variant/visitor-no-copy branch
2016-01-27 14:50:17 +01:00
artemp
c7a964abf6
disable "point unitialized" test for boost >= 1.50 (pending reviewing https://github.com/mapnik/mapnik/issues/3218 )
2016-01-27 14:48:57 +01:00
Dane Springmeyer
c037fcba36
fix shapeindex tests - closes #3252
2016-01-25 16:57:32 -08:00
artemp
db9facef90
update submodules
2016-01-25 10:04:10 +01:00
Artem Pavlenko
f17b11a1e5
Merge pull request #3251 from lightmare/svg-parser-test
...
Fix #3249 and make parse_svg_value more strict
2016-01-25 09:58:14 +01:00
Mickey Rose
05b66fc355
refactor svg_parser_test
...
- moved some boilerplate to helper struct test_parser
- added REQUIRE(!parse...) to parsing error tests
- changed parsing error tests to compare full error lists instead of
just count and then individual messages (if count was different, you
were left in the dark with no messages at all)
- changed some double-quotes in errors to single-quotes
(corresponding change to parser follows)
2016-01-23 20:21:05 +01:00
Tom Hughes
72297c9431
Adapt geometry tests got changes in boost 1.60
...
The issues with points at NaN and infinity bring considered as
valid reported in https://svn.boost.org/trac/boost/ticket/11711 has
been fixed in boost 1.60 so the tests need to reflect that.
Also per https://svn.boost.org/trac/boost/ticket/11710 empty
polygons are now considered invalid, and hence not simple.
2016-01-23 14:43:02 +00:00
Blake Thompson
5e30aee4e7
Added missing required header from unit test
2016-01-22 11:02:12 -06:00
artemp
f140cc7dd1
update submodules
2016-01-21 18:52:24 +01:00
artemp
a3ed9ad07e
value test - improve coverage
2016-01-21 18:36:41 +01:00
artemp
a707d5cd65
test svg - refactor common code into separate *.hpp
2016-01-21 18:14:17 +01:00
artemp
74776631c5
add value tests
2016-01-21 12:48:36 +01:00
artemp
be7a70746c
image_io_test - increase coverage
2016-01-20 13:43:01 +01:00
artemp
c36ae3964a
image_io_test : add basic save options tests
2016-01-20 13:39:32 +01:00
artemp
2db9818ab9
image_io_test : add 'save_to_xxx' tests
2016-01-20 12:24:08 +01:00
artemp
5471f519cd
box2d - add missing tests
2016-01-19 12:15:50 +00:00
artemp
19c8b3e581
mapnik::color + increase unit test coverage (operator<<, to_string(), premultiply/demultiply)
2016-01-19 11:39:12 +00:00
mapsam
7a98745883
adding new passing test that catches failure of feature collection properties
2016-01-15 08:37:30 -08:00
Dane Springmeyer
5a6de7627b
improve formatting of INFO output [skip ci]
2016-01-14 16:10:10 -08:00
Dane Springmeyer
bba2826813
make available test functions as macros to allow catch to report correct line numbers
2016-01-14 16:06:20 -08:00
Artem Pavlenko
c82b5c50c6
Merge pull request #3234 from mapnik/svg-tests
...
More SVG visual tests (testing tuesday 01/12/2016)
2016-01-14 16:19:55 +00:00
artemp
cc635df7bc
svg_parser - use parse_svg_value
2016-01-14 11:03:55 +00:00
artemp
8ab10d0231
update test
2016-01-14 10:56:05 +00:00
jakepruitt
ebc0f2eb8b
Removed random tests from reference images
2016-01-13 15:37:56 -07:00
jakepruitt
de9023f5e0
Add circle tests
2016-01-13 15:20:01 -07:00
mapsam
3b79892ae5
svg test for multiple command parts, #3229 & #3225
2016-01-12 15:28:40 -08:00
jakepruitt
12d970ff8d
Change octocat svg width
2016-01-12 13:37:03 -07:00
jakepruitt
e933f9ec40
Update new octocat fixture
2016-01-12 11:10:09 -07:00
artemp
37d586d701
Unit tests - add SVG path parsing tests
2016-01-12 15:08:02 +00:00
Dane Springmeyer
488af4055d
Reduce merge conflicts with master
2016-01-11 16:23:04 -08:00
Dane Springmeyer
40fed664df
more visual test updates
2016-01-11 14:10:46 -08:00
Dane Springmeyer
6036711148
update to latest visual test images
2016-01-11 14:02:57 -08:00
Dane Springmeyer
4e26932868
use latest visual test data
2016-01-11 13:48:48 -08:00
Dane Springmeyer
31958352bc
Merge pull request #3213 from mapycz/fix-visual-tests-init
...
visual tests: fix vector initialization
2016-01-06 09:02:30 -08:00
Dane Springmeyer
1687f6ff1b
add custom command line options to unit tests - refs philsquared/Catch#381
2016-01-05 17:13:36 -08:00
Dane Springmeyer
ca3b0c43e7
upgrade catch.hpp
2016-01-05 16:42:36 -08:00
Dane Springmeyer
96dff395a4
fix usage of base in csv unit tests
2016-01-05 15:18:02 -08:00
artemp
869bff43f0
remove debug printing
2016-01-04 15:15:37 +00:00
artemp
b513d6a07b
don't export DYLD_LIBRARY_PATH multiple times
2016-01-04 14:24:25 +00:00
artemp
102671e498
add test with --index-parts option
2016-01-04 14:22:09 +00:00
Jiri Drbalek
9ad6ee2999
visual tests: fix vector initialization
2015-12-28 09:30:46 +00:00
Dane Springmeyer
75cb954d26
update test-data to include new postgis sql
2015-12-14 15:27:48 -08:00
Dane Springmeyer
fc6556170d
let's not depend on CREATE EXTENSION working in C++ code
2015-12-14 15:27:05 -08:00
Dane Springmeyer
b42f072ad3
wip: start chipping away at getting tests running - refs #3180
2015-12-14 15:00:10 -08:00
Dane Springmeyer
dc109a7ae2
Merge branch 'master' of github.com:mapnik/mapnik into postgis-tests-squashed
2015-12-14 13:45:29 -08:00
artemp
5e2f3ce61d
geojson/geometry - update unit test
2015-12-14 11:46:39 +00:00
artemp
e65cb96743
sync expressions tests with spirit-x3 branch
2015-12-08 16:39:32 +00:00
artemp
327ba670ff
expressions unit test - add relational and regex tests
2015-12-08 16:25:59 +00:00
artemp
319651c33a
expressions unit test - add logical expr
2015-12-08 14:25:02 +00:00
artemp
10cd9cd0fd
unit test - expression parsing/evalution test
2015-12-08 14:25:02 +00:00
artemp
e2cf79260f
unit tests - add 'ensure original ordering in geojson.input' test ref #3182
2015-11-25 12:46:21 +00:00
Jiri Drbalek
100e3c4995
centroid: enable algorithm on multi-geometries with empty sub-geometries
2015-11-24 15:41:34 +00:00
artemp
a2b1475ef7
port shapeindex_test.py to c++ ( #3184 )
2015-11-24 10:50:09 +00:00
artemp
7aa97628e0
revert accidentally pushed changes from WIP branch
2015-11-20 19:55:21 +00:00
artemp
4fffcdd612
update test data
2015-11-20 17:11:52 +00:00
bergwerkgis
b4a7b594dd
1st iteration of PostGIS tests
2015-11-20 15:44:43 +01:00
artemp
44eb1b69fa
revert test-data
2015-11-20 14:13:13 +00:00
artemp
e0d7f8ffcb
update test data
2015-11-20 14:10:44 +00:00
artemp
d373ae2e93
update visual-data
2015-11-17 15:28:25 +00:00
Artem Pavlenko
4e922f6a64
Merge pull request #3164 from mapycz/postgis-empty-geoms
...
check input data of centroid algorithm
2015-11-11 10:21:39 +00:00
Jiri Drbalek
6066946ef2
add unit tests for is_empty and has_empty
2015-11-10 13:49:22 +00:00
Jiri Drbalek
071eeeb660
centroid algorithm: check for empty geometries
2015-11-10 13:49:12 +00:00
artemp
617400f1a1
unit test - add malformed FeatureCollection test where we expect exception to be thrown in featureset::next() method even when mapnik-index creates *.index file (expected due to optimised parsing)
2015-11-10 11:37:48 +00:00
Dane Springmeyer
58f30f3d42
more CSV test coverage - refs #3098
2015-11-09 10:47:07 -08:00
Dane Springmeyer
53174718d8
use mapnik/warning_ignore.hpp in a few more places
2015-11-09 09:51:35 -08:00
Dane Springmeyer
de1d1b902a
Merge pull request #3163 from mapycz/fix-offsetting-test
...
unit test: fix offsetting test
2015-11-07 12:42:08 -08:00
artemp
b85055ee38
unit test - add malformed "Feature" tests
2015-11-06 11:50:25 +00:00
Jiri Drbalek
c7de93ae76
unit test: fix offsetting test
2015-11-05 13:38:40 +00:00
Dane Springmeyer
da624b9ef4
update test-data to pull in 9f471a25e3 -refs #3160
2015-11-04 13:57:14 -08:00
artemp
a2975c0d23
unit test - check values stored as expected types in mapnik::value
2015-11-03 15:17:43 +00:00
bergwerkgis
4325fcb26d
Windows tests: fix missing "M_PI"
2015-11-03 13:22:51 +00:00
artemp
2893ee4551
mapnik::value - add missing specialisations for mapnik::value_bool in comparison operators + update unit tests
2015-11-03 10:11:29 +00:00
artemp
96c2fc9076
image - update unit test re: cb31692f37
2015-11-02 10:27:11 +00:00
artemp
ab7040d96a
and again :)
2015-10-30 10:01:33 +00:00
artemp
16355533c7
update test data
2015-10-30 09:57:29 +00:00
Dane Springmeyer
e505c94583
start postgis datasource tests
2015-10-29 09:48:49 -07:00
Dane Springmeyer
3c007cee9e
better debug output when test fails
2015-10-29 09:48:09 -07:00
Dane Springmeyer
1106654d40
[unit] move some code from csv test to header
2015-10-29 09:23:54 -07:00
Dane Springmeyer
a9814f25f0
more test include gardening
2015-10-29 08:35:45 -07:00
Dane Springmeyer
5090b103e4
try to speed up compile of tests by cleaning up unused includes/cruft
2015-10-29 08:20:46 -07:00
Dane Springmeyer
aa6a06116b
remove test, now covered by tests at https://github.com/mapbox/mapnik-vector-tile
2015-10-29 08:06:25 -07:00
Dane Springmeyer
1ac12a4430
add hint of how to compile geojson unit test without scons
2015-10-29 08:01:36 -07:00
artemp
e9a6182ff7
update test data
2015-10-28 09:26:32 +00:00
Dane Springmeyer
646bcbcbd9
don't depend on filesystem directly
2015-10-23 10:39:55 -07:00
Dane Springmeyer
cf36c78812
fix #3143
2015-10-23 10:39:34 -07:00
artemp
c10263764c
geojson unit test - add invalid Point test
2015-10-23 14:17:41 +01:00
artemp
69829e028d
add simple I/O error test when file does not exist
2015-10-23 14:11:17 +01:00
artemp
b0bcf86aaa
clean up -> remove *.index
2015-10-23 13:17:18 +01:00
artemp
35a420927e
follow naming convention
2015-10-23 13:12:19 +01:00
artemp
aaa5a73105
add disk index tests
2015-10-23 13:11:08 +01:00
artemp
34ffdaa3ef
use anonimous namespace + default arg in create_disk_index
2015-10-23 13:09:21 +01:00
artemp
7a1ab599ba
move csv_test to unit/datasource
2015-10-22 18:32:23 +01:00
Dane Springmeyer
5fe7367231
bypass expected error condition - refs #3125
2015-10-22 10:28:31 -07:00
Dane Springmeyer
73e9804384
geojson test coverage of 'base' parameter
2015-10-22 08:45:34 -07:00
Dane Springmeyer
a05746180d
fix another cache-features -> cache_features
2015-10-22 08:19:39 -07:00
artemp
d2c02dae54
fix the rest of cache-features names
2015-10-22 16:13:08 +01:00
artemp
3b1b15f64b
fix parameter name and improve coverage
2015-10-22 15:53:23 +01:00
artemp
e63405626b
cleanup
2015-10-22 15:12:17 +01:00
artemp
dd95662648
CSV - add more tests
2015-10-22 15:11:18 +01:00
Dane Springmeyer
00154c2dfb
add test coverage of geojson features_at_point
2015-10-21 12:37:30 -07:00
Dane Springmeyer
669bca884e
more coverage of geojson get_geometry_type
2015-10-21 09:15:44 -07:00
artemp
9f439d1e2e
unit test geojson - only expect CHECK_THROW when *.index is not present. Bounding box extractor parser is not strict in the sense that it doesn't require input to be fully consumed (i.e it can handle extra traling characters).
2015-10-21 11:33:24 +01:00
Dane Springmeyer
56d8516216
increase test coverage of get_geometry_type
2015-10-20 23:17:44 -07:00
Dane Springmeyer
14589dabd1
improve test coverage of geojson indexing
2015-10-20 22:56:03 -07:00
Dane Springmeyer
9df548670c
manually inherit DYLD_LIBRARY_PATH - closes #3138
2015-10-20 17:22:52 -07:00
Dane Springmeyer
d1c5c69f07
Also dump posix return (aka WEXITSTATUS)
2015-10-20 15:18:12 -07:00
Dane Springmeyer
1df6fbb17e
dump std::system return code if index is not found
2015-10-20 12:23:05 -07:00
Dane Springmeyer
2c72833629
Revert "travis - std::system() calls fails"
...
This reverts commit 5de3a3776d
2015-10-20 12:19:06 -07:00
artemp
5de3a3776d
travis - std::system() calls fails
2015-10-20 13:50:54 +01:00
artemp
4822477d40
don't rely on std::system return value (implementation defined)
2015-10-20 12:44:45 +01:00
artemp
aa537e6254
geojson unit test - further simplify and increase coverage
2015-10-20 12:04:32 +01:00
artemp
c4ec93a5f2
geojson unit test - run 'FeatureCollection' test using all permutations of disk_index and cache_features settings.
2015-10-20 11:46:39 +01:00
artemp
daaf2ee9d5
unit test (geojson) - de-dupe code
2015-10-20 11:22:42 +01:00
artemp
d9a66a765c
unit/geojson - add basic test for *.index access mode
2015-10-19 16:58:32 +01:00
artemp
4b5bbe9446
unit test(geojson) - add tests reading all geometry primitives
2015-10-19 12:23:43 +01:00
artemp
4976a7c72a
update test data
2015-10-16 17:42:39 +01:00
artemp
b15dba95cd
unit test - add malformed JSON test + update test data
2015-10-14 11:41:14 +01:00
Dane Springmeyer
01d3c91de4
only run test if plugins exist
2015-10-07 14:41:07 -07:00
Dane Springmeyer
3b8bcacb91
latest visual test data with updated postgis/cairo fixtures
2015-10-06 19:10:14 -07:00
Dane Springmeyer
b7a54f3f09
warn if boost is too old to run tests
2015-10-06 15:39:42 -07:00
Dane Springmeyer
64f2628488
use latest visual test data after cairo change in 4b490fb - refs mapnik/test-data-visual#23
2015-10-06 15:39:42 -07:00
Dane Springmeyer
5915c4e7a5
fix test compile with older boost
2015-10-06 07:32:51 -07:00
Wilhelm Berg
4cfd692be2
Merge pull request #3109 from mapnik/visual-test-results
...
visual diff of visual test results
2015-10-06 14:03:22 +02:00
artemp
0bd7a980f3
unit test - add `query_first_n' test
2015-10-06 11:42:34 +01:00
Blake Thompson
c127620b6c
Updated the way that is_valid and is_simple operate in mapnik and added lots of testing around them.
2015-10-05 15:10:24 -07:00
artemp
63c73b5057
add initial 'qoute' auto-detection + restore csv_test's
2015-10-05 16:56:33 +01:00
artemp
93a237850b
fix spatial_index test after de9de659c3772fdf232a3c24f5c254a0a86046b9
2015-10-05 15:28:57 +01:00
bergwerkgis
5fd6f33c0f
visual diff of visual test results
2015-10-05 14:23:52 +00:00
artemp
1bccca9ff8
Merge remote-tracking branch 'origin/master'
...
Conflicts:
plugins/input/csv/csv_datasource.cpp
2015-10-02 12:27:28 +01:00
artemp
1d320b7133
make quote single char
2015-10-02 12:20:54 +01:00
Dane Springmeyer
2f9c9bd4b1
update test data - closes #3102
2015-10-01 15:46:07 -07:00
Dane Springmeyer
a8019f9fa2
log csv filepath when test fails [skip ci]
2015-10-01 13:35:23 -07:00
Dane Springmeyer
be22a67b60
fix -Wshadow warnings
2015-10-01 13:35:23 -07:00
artemp
4273e37278
Merge branch 'master' into csv-disk-index
2015-10-01 15:26:47 +01:00
Dane Springmeyer
0c23eaa4ba
fix variable shadowing in image_filter unit test
2015-09-30 14:23:00 -07:00
artemp
54609fd8ac
remove blank undelimited rows are still parsed section as current behavior is to fail and continue on individual row errors
2015-09-30 15:40:42 +01:00
artemp
81628d5b9c
update test visual-data
2015-09-30 15:31:56 +01:00
bergwerkgis
8e7e7c64a7
update test-data-visual to force LF for SVGs on clone (Windows)
2015-09-30 13:07:52 +00:00
artemp
848098baeb
spatial_index/quad_tree - remove `operator>>' requirement, instead value_type stored must have standard layout for correct (de)serialisation + update unit test
2015-09-29 15:44:57 +01:00
artemp
f549cae46a
unit test - add initial spatial_index tests
2015-09-29 12:27:56 +01:00
artemp
08a30cbbd9
update test data
2015-09-28 14:29:54 +01:00
jakepruitt
a787d20e36
Add viewbox fallback logic for dimension parsing
...
SVG's now have fallback on viewbox. Still debugging the boost Qi parser
2015-09-25 12:05:57 -07:00
artemp
8c2f15c94a
mapnik::value - always upcast to the higher definition numeric value (rhs or lhs) in operator== and operator!=
...
add unit test for comparing numeric mapnik::values
2015-09-24 17:38:16 +01:00
Jiri Drbalek
91db109b37
fix parsing colors in hexadecimal notation
2015-09-18 13:54:05 +00:00
Jiri Drbalek
ae8ac89ef8
visual tests: add command line parameters for scale-factor settings
2015-09-17 08:22:18 +00:00
Jiri Drbalek
fd19c754f3
visual tests: command line switches for renderers
2015-09-17 08:22:10 +00:00
artemp
e452a03c09
update test data
2015-09-16 18:30:37 +01:00
artemp
d54eca9dca
image - fix copy/move implementation and update/improve tests
2015-09-16 14:28:55 +01:00
artemp
60c79d6614
image unit test - make test image 16x16 + add more checks
2015-09-16 11:47:36 +01:00
artemp
c1301fa142
image unit test - add copy (deep/shallow) + move tests
2015-09-16 11:37:46 +01:00
artemp
8c8ea74a63
update unit test
2015-09-16 10:15:21 +01:00
Artem Pavlenko
c4e0516ba6
Merge pull request #3061 from mapycz/colorize-alpha
...
colorize-alpha: add support for transparent colors
2015-09-15 16:11:28 +01:00
Dane Springmeyer
b2d08ea4ea
re-enable zero allocation image interface - refs #3069
2015-09-14 16:45:58 -07:00
Jiri Drbalek
6f0b4d438c
colorize-alpha: add support for transparent colors
2015-09-11 11:31:08 +00:00
artemp
a5bba97192
update data
2015-09-08 13:10:41 +02:00
Artem Pavlenko
282bdf178c
Merge pull request #3058 from mapycz/colorize-alpha-fix-color-value-normalization
...
colorize-alpha: fix normalization of color components
2015-09-08 12:50:46 +02:00
Jiri Drbalek
79f4e3ac8f
colorize-alpha: fix normalization of color components
2015-09-08 10:14:20 +00:00
Jiri Drbalek
72222efad7
scale-hsla image filter: unlimit parameters
2015-09-03 11:33:53 +00:00
artemp
1080d92a79
add missing geometry type check
2015-08-27 13:07:51 +02:00
artemp
10e6128035
test/data -> track master
2015-08-26 11:23:22 +02:00
Artem Pavlenko
26d100f3d9
Merge pull request #2996 from mapycz/improve-visual-test-11
...
visual tests: limit number of failures
2015-08-26 10:33:57 +02:00
Artem Pavlenko
85eebaaf57
Merge pull request #3038 from zerebubuth/fix/deadlock-in-recursive-datasource-registration
...
Fix deadlock in recursive datasource registration.
2015-08-25 15:07:00 +02:00
Matt Amos
3d7b84a598
Fix deadlock in recursive datasource registration.
...
The datasource cache was taking an exclusive lock on the simple
mutex used to protect the singleton's data pointer. This works
okay when everyone always calls it non-recursively, but when the
recursive flag is true then it will always deadlock when called
on any directory with subdirectories.
Additionally, many methods which accessed private data members of
the cache were not protected by any locks.
Since the call pattern of registering datasources is strictly
tree-shaped then it's a good candidate for a recursive mutex. This
has a slightly higher overhead than a simple mutex, so rather than
change the singleton's mutex to be recursive, I've added a new
instance mutex to the datasource cache.
Also, added a very basic test which reproduces the problem and
shows that it's fixed with this patch.
2015-08-23 20:25:35 +01:00
artemp
4babec802a
CSV - implement spatial index access to features on disk + preserve support for inline data (work-in-progress)
2015-08-21 13:52:42 +02:00
artemp
d7e2f63f89
remove debug stderr + update data
2015-08-19 12:40:01 +02:00
artemp
710ec057e5
formatting
2015-08-19 12:04:45 +02:00
artemp
153c93d345
Merge branch 'master' into large_csv
2015-08-19 12:02:50 +02:00
artemp
f8afa796d7
update test data
2015-08-17 16:56:00 +02:00
artemp
0ba2e3f3f6
update svg tests
2015-08-17 16:53:42 +02:00
artemp
2b25f025cf
update 'test/data' submodule to track 'large_csv' branch
2015-08-14 11:35:37 +02:00
artemp
28a7bdfd7c
update test data
2015-08-14 11:12:44 +02:00
artemp
f7d1cf82a9
Merge branch 'master' into large_csv
2015-08-13 13:28:35 +02:00
artemp
3e3ab2cd4b
update test
2015-08-12 11:35:26 +02:00
artemp
ebf4d66900
Merge branch 'master' into image_filters
2015-08-12 11:27:59 +02:00
